refactor: convert test suites to JUnit 5 and make test classes package-private #1255
+851
−659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaodinissf
force-pushed
the
junit-test
branch
from
b9e5e5c to
45ad1de
Compare
joaodinissf
changed the title
joaodinissf
force-pushed
the
junit-test
branch
from
45ad1de to
1f986ca
Compare
joaodinissf
changed the title
Replace GitHub Action PMD with Maven-based PMD job for version consistency with ddk-parent/pom.xml. Add separate Checkstyle job. Both run in parallel with maven-verify for faster feedback on style violations. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The cast clarifies that ProxyModelAssociationsAdapter is an Adapter through its inheritance chain. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove AllTests.java and XtextTestSuite.java - JUnit 5 @SelectPackages doesn't work with OSGi bundleresource:// URIs - Add <includes> pattern for *Test.java in tycho-surefire-plugin - Let Tycho discover tests by naming convention instead - Remove ExportScopingTest.xtext (was added for testing, not in master)
- Rename BugAig1314, BugDsl27, BugAig1084 to *Test suffix so they match
JUnit 5 default class name pattern and Tycho's **/*Test.java convention
- Add missing expression package to GeneratorTestSuite @SelectPackages
- Add @IncludeClassNamePatterns(".*Test.*") to all suites for consistency
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
joaodinissf
force-pushed
the
junit-test
branch
from
1f986ca to
29805e2
Compare
…sses Fix PMD PublicMemberInNonPublicType violations: constructors, methods, fields, and inner classes that were still public in package-private test classes are now package-private. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@SelectClassesto JUnit 5@SelectPackages+@SuiteJUnit5TestShouldBePackagePrivateruleBugAig1314,BugDsl27,BugAig1084to*Testsuffix for JUnit 5 / Tycho discoverability@IncludeClassNamePatterns(".*Test.*")consistently across all test suites@SuppressWarningsannotations (restriction,unchecked) where no longer neededNotes
@SelectPackagesdoes not work with OSGibundleresource://URIs; test discovery relies on Tycho's**/*Test.javasurefire convention. The suite annotations serve as documentation and for non-OSGi execution.@SuppressWarningscleanup touches non-test files — these are valid but tangential to the JUnit 5 migration.Test plan